Skip to content

chore(ast-grep): upgrade to ast-grep 0.51.3 - #702

Merged
theCodeDrift merged 2 commits into
mainfrom
chore/ast-grep-0-51-3
Nov 17, 2026
Merged

theCodeDrift merged 2 commits into
mainfrom
chore/ast-grep-0-51-3

Conversation

@theCodeDrift

Copy link
Copy Markdown
Member

Lands the machine-generated ast-grep bump from #698 laterally, with the repair that makes it green.

The bump commit is #698's, rebased onto current main (it was 12 commits behind). It moves every @ast-grep/cli* pin from 0.51.1 to 0.51.3, AST_GREP_VERSION, and the vendored rule schema.

#698 failed on one test: dogfood-scaffold-current found this repository's own rules still recorded against sg 0.51.1. The second commit records the update walk (0.13.6 → 0.13.7, no ledger entries apply) with pnpm cli update --rules, which moves reconciledTo and rules.engines.sg in .taskless/taskless.json. Nothing else changes.

ast-grep-vendor-contract was already green on #698, so 0.51.3 adds no language and changes no measured behaviour: no capability edit, no ledger entry, and the bot's patch changeset stands as written.

Verified locally: lint, typecheck, build, test, test:scripts, cli check, cli verify, openspec validate --all --strict, and the spec visibility check all pass.

Closes #698

@theCodeDrift

Copy link
Copy Markdown
Member Author

@claude /review

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @theCodeDrift's task in 52s —— View job


Review complete ✅

Review mode: incremental — read 0 prior review thread(s) before reviewing. .prior-review.json contained no prior reviews, review threads, or top-level comments beyond the trigger comment itself, so this is the first review of this PR; the full diff was assessed.

  • Read .prior-review.json (no prior threads/reviews/comments to classify against)
  • Fetch PR diff and metadata (gh pr diff, gh pr view --json commits,headRefOid,files)
  • Review changed files (.changeset/ast-grep-0-51-3.md, .taskless/taskless.json, packages/cli/package.json, packages/cli/src/generated/ast-grep-rule-schema.json, packages/cli/src/rules/capabilities.ts, pnpm-lock.yaml)
  • Post findings

Assessment

This is a clean, mechanical version bump with no findings. What I checked specifically:

  • Version consistency: AST_GREP_VERSION in packages/cli/src/rules/capabilities.ts:42, the @ast-grep/cli* pins in packages/cli/package.json, the $comment in packages/cli/src/generated/ast-grep-rule-schema.json, and rules.engines.sg in .taskless/taskless.json all agree on 0.51.3. No stray 0.51.1 references remain in the diffed files.
  • Language capability list unchanged: AST_GREP_LANGUAGES in capabilities.ts is untouched by this diff, which matches the PR body's claim that 0.51.3 adds no language and the vendor contract test (test/ast-grep-vendor-contract.test.ts, not touched here) was already green on chore(ast-grep): upgrade to ast-grep 0.51.3 #698. I didn't re-run that test, but the claim is internally consistent with the diff.
  • Node engine floor: the upgraded pnpm-lock.yaml entries bump each @ast-grep/cli-* binary's required engine from node >= 10/>= 12.0.0 to node >= 20.0.0. packages/cli/package.json already declares "engines": { "node": ">=22.22.0" }, so this tightened floor is already satisfied — no action needed, but worth having verified since a silent floor bump like this is exactly the kind of thing that can break downstream unnoticed.
  • New musl optional deps (@ast-grep/cli-linux-arm64-musl, @ast-grep/cli-linux-x64-musl) appear only inside the pnpm-lock.yaml snapshot for @ast-grep/cli@0.51.3's own optionalDependencies — they're upstream's own platform list, not something packages/cli/package.json's optionalDependencies needs to mirror (that list is Taskless's own supported-platform set, unchanged here). Correct as-is.
  • .taskless/taskless.json: reconciledTo moving 0.13.6 → 0.13.7 matches packages/cli/package.json's current "version": "0.13.7", consistent with the PR body's description of pnpm cli update --rules recording the walk with no ledger entries.
  • Changeset: .changeset/ast-grep-0-51-3.md correctly scopes this as a patch for @taskless/cli.
  • No stale lockfile artifacts: pnpm-lock.yaml's diff is scoped entirely to the @ast-grep/cli* entries (version bumps, updated integrity hashes, new musl variants, engine floor) — no unrelated churn.

Nothing new to raise. No limitations encountered — this review did not need to run the build/lint/test suite, since the change is a self-consistent set of version-string edits verifiable by direct comparison across the diffed files.
(branch)

@theCodeDrift
theCodeDrift merged commit cf95925 into main Nov 17, 2026
9 checks passed
@theCodeDrift
theCodeDrift deleted the chore/ast-grep-0-51-3 branch November 17, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant